Point five stale doc paths at the moved files - #6388
Merged
Merged
Conversation
melbinjp
requested review from
ChrisJBurns,
JAORMX,
amirejaz,
aponcedeleonch,
blkt,
jerm-dro,
jhrozek,
rdimitrov,
reyortiz3 and
tgrunnagle
as code owners
August 19, 2026 16:02
jhrozek
approved these changes
Aug 19, 2026
Three of them are in docs/server/README.md, which is itself in docs/server/ and names its own neighbours one directory up: swagger.json, swagger.yaml and docs.go moved together in 0da4f9a (stacklok#448). The other two name pkg/vmcp/server/telemetry.go, which became pkg/vmcp/internal/backendtelemetry/backendtelemetry.go in 87fa2ac (stacklok#5457). Git recorded all five as renames, so each destination is verified present and each source verified absent at 0b8acf2. No prose changes. Part of stacklok#6387, which lists ten more that need a judgement from inside the project rather than a patch from outside. Signed-off-by: Melbin J Paulose <melbinjpaulose@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6388 +/- ##
==========================================
+ Coverage 77.71% 77.72% +0.01%
==========================================
Files 759 759
Lines 72889 72889
==========================================
+ Hits 56646 56655 +9
+ Misses 16238 16229 -9
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jhrozek
pushed a commit
that referenced
this pull request
Sep 16, 2026
Follow-up to #6388, which fixed the five plain renames from #6387. These are the rest, re-measured against e532cf0 rather than re-quoted from the issue: one had moved again since it was filed, and pkg/skills/feature_gate.go is already gone from the docs, so it is nine rather than ten. Four moved to toolhive-core, and the replacement is the import path the Go code uses today: pkg/permissions/profile.go -> toolhive-core/permissions pkg/registry/types.go -> toolhive-core/registry/types pkg/container/verifier/ -> toolhive-core/container/verifier pkg/errors/errors.go -> toolhive-core/httperr pkg/runner/retriever/retriever.go imports the verifier one, and docs/error-handling.md already used httperr.Code in the example directly above the list that still named pkg/errors. pkg/registry/schema_validation.go is named as the validator for schemas the same document already says are published in toolhive-core, so it points there too. pkg/vmcp/discovery/ is not in the tree. Discovery is, in pkg/vmcp/aggregator/discoverer.go, so the three references name the aggregator rather than dropping the idea. The vmcp-library row is removed because it lists a package that no longer exists and already said to use it via the aggregator. Every destination checked at e532cf0: the four toolhive-core links resolve, and the five in-tree paths are present. Signed-off-by: Melbin J Paulose <melbinjpaulose@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five documented paths point at files that moved. Git recorded all five as renames, so there
is no judgement in this one: each destination verified present and each source verified
absent at
0b8acf26.docs/server/README.md:27docs/swagger.jsondocs/server/swagger.jsondocs/server/README.md:28docs/swagger.yamldocs/server/swagger.yamldocs/server/README.md:29docs/docs.godocs/server/docs.godocs/operator/virtualmcpserver-observability.md:27pkg/vmcp/server/telemetry.gopkg/vmcp/internal/backendtelemetry/backendtelemetry.godocs/telemetry-migration-guide.md:250pkg/vmcp/server/telemetry.goThe first three moved together in
0da4f9a8("refactor: openapi, add readme", #448), and theREADME that names them is itself in
docs/server/- it points one directory up at its ownneighbours. The other two moved in
87fa2ac8("Implement stateless core VMCP constructor",#5457).
Five lines, three files, no prose changes.
Part of #6387. The other ten findings there are not in this pull request on purpose: they are
subsystems that left for
toolhive-core, code removed as dead, and a feature that no longerexists, and the right fix for each is a judgement from inside the project rather than a patch
from outside.
Found by docproof, a documentation checker that
resolves documented paths against the repository and its git history.